[wp-trac] [WordPress Trac] #28620: When $depth argument is used in wp_nav_menu last level menu items still have .menu-item-has-children class, even though they are not shown

WordPress Trac noreply at wordpress.org
Tue Oct 11 10:03:52 UTC 2016


#28620: When $depth argument is used in wp_nav_menu last level menu items still
have .menu-item-has-children class, even though they are not shown
-------------------------------------------------+-------------------------
 Reporter:  slobodanmanic                        |       Owner:  chriscct7
     Type:  defect (bug)                         |      Status:  reviewing
 Priority:  normal                               |   Milestone:  Future
Component:  Menus                                |  Release
 Severity:  normal                               |     Version:  3.7
 Keywords:  good-first-bug needs-testing has-    |  Resolution:
  patch                                          |     Focuses:  ui
-------------------------------------------------+-------------------------
Changes (by mdgl):

 * type:  enhancement => defect (bug)


Comment:

 Alternative patch added, which avoids adding the incorrect class names at
 source. This might be considered preferable. It will use a little more
 time/space but this shouldn't be a problem as most menus will be
 (relatively) short and shallow. Also re-categorised ticket as a "bug".

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28620#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list