[wp-trac] [WordPress Trac] #37974: Add multi-panel feature to pages through add_theme_support
WordPress Trac
noreply at wordpress.org
Mon Oct 10 21:05:59 UTC 2016
#37974: Add multi-panel feature to pages through add_theme_support
----------------------------+------------------
Reporter: karmatosed | Owner:
Type: task (blessed) | Status: new
Priority: normal | Milestone: 4.7
Component: Themes | Version:
Severity: normal | Resolution:
Keywords: ux-feedback | Focuses: ui
----------------------------+------------------
Comment (by bradyvercher):
@pento Thanks! The change in [attachment:37974.2.diff] is pretty dang
cool. Handling sections like that hadn't even crossed my mind, but I
really like that approach.
> I think it's worth investigating having http://example.com/about/
redirected to http://example.com/#about, rather than #post-65. This is a
bit trickier, of course, but much nicer.
I waffled on that myself. I prefer the more readable format, but I see the
post ID used as the anchor more often. The only thing that comes to mind
is to introduce something like `the_anchor()` or `the_html_id()` to let
core control the output for the HTML `id` attribute.
Replying to [comment:97 @karmatosed]:
It looks like you might be missing some of the styles. Those move up/down
arrows should definitely be showing up as well as a button to remove
pages. I could have botched the patch, but it looks like everything should
be there. Depending on your setup, you might need to run the Grunt task?
> It seems that the page template always has to be the top content. Is
that the case?
Right now that's the way it's set up since sections are appended to the
front page, which is consistent with the way the front page currently
works.
> There also is a little odd behaviour where if I don't search I can click
'x' on search and loose all pages shown.
I fixed that up in [attachment:37974.3.diff], which also includes these
updates based on the feedback from [comment:99 @davidakennedy]:
* A divider between existing front page controls and the new section
control
* The front page and page for posts are excluded from search results
* Added a `front-page-section` class in `post_class()`
Aside from further tightening up the UI, I think that leaves pretty
anchors, comments, and potentially making the preview instantly update
when reordering sections instead of doing a refresh.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/37974#comment:100>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list