[wp-trac] [WordPress Trac] #34891: get_submit_button uses incorrect check for delete class

[WordPress Trac]

#34891: get_submit_button uses incorrect check for delete class
-------------------------------------+---------------------------------
 Reporter:  rmccue                   |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Administration           |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  ui-feedback needs-patch  |     Focuses:  ui, administration
-------------------------------------+---------------------------------
Changes (by afercia):

 * keywords:  ui-feedback => ui-feedback needs-patch


Comment:

 Seems the relevant changeset is [21789]: there was a `switch` before the
 change and as far as I see the `delete` case was there just to ensure the
 `delete` class was always paired with `button-secondary`. Maybe those two
 lines could be removed now since `button-secondary` should not be used
 (it's not responsive and doesn't reset the outline property on focus) and
 the default behaviour is to always have the base `button` class so the
 result is `button delete`.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34891#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform