[wp-trac] [WordPress Trac] #23477: r21789 creates a breaking change in behavior for get_submit_button

[WordPress Trac]

#23477: r21789 creates a breaking change in behavior for get_submit_button
-----------------------------------------+------------------------------
 Reporter:  vhauri                       |       Owner:
     Type:  defect (bug)                 |      Status:  new
 Priority:  normal                       |   Milestone:  Awaiting Review
Component:  Administration               |     Version:  3.5
 Severity:  normal                       |  Resolution:
 Keywords:  has-patch ui-feedback close  |     Focuses:  ui
-----------------------------------------+------------------------------

Comment (by SergeyBiryukov):

 For reference, the core usage of `secondary` and `button-secondary` was
 cleaned up (as suggested in [attachment:allow-secondary-button-
 class.patch]) in [35182] and [38672].

 The docs, however, still mention `secondary`:
  * `submit_button()`:
 {{{
  * @param string       $type             Optional. The type and CSS
 class(es) of the button. Core values
  *                                       include 'primary', 'secondary',
 'delete'. Default 'primary'
 }}}
  * `get_submit_button()`:
 {{{
  * @param string       $type             Optional. The type of button.
 Accepts 'primary', 'secondary',
  *                                       or 'delete'. Default 'primary
 large'.
 }}}

 It might be a good idea to remove it from here too.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/23477#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform