[wp-trac] [WordPress Trac] #36901: Removing wp_die() from wp_allow_comment()

[WordPress Trac]

#36901: Removing wp_die() from wp_allow_comment()
-------------------------------------------------+-------------------------
 Reporter:  websupporter                         |       Owner:
     Type:  enhancement                          |  websupporter
 Priority:  normal                               |      Status:  reviewing
Component:  Comments                             |   Milestone:  4.7
 Severity:  normal                               |     Version:  4.6
 Keywords:  has-patch needs-testing has-unit-    |  Resolution:
  tests                                          |     Focuses:
-------------------------------------------------+-------------------------

Comment (by rachelbaker):

 Replying to [comment:26 mdgl]:
 > The other backwards-compatibility issue I can think of is that now
 calling function `check_comment_flood_db()` will effectively do nothing,
 whereas previously it actually checked for a comment flood and "died" if
 one was detected.  Developers may be relying on that behaviour.

 `check_comment_flood_db()` is never called directly by WordPress itself.
 We can check the plugin repo to see if/how many are directly calling that
 function.  I think this change does warrant a post on Make Core to
 communicate the change.

 cc @websupporter

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36901#comment:30>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform