[wp-trac] [WordPress Trac] #37217: get_network_by_path should use WP_Network_Query

[WordPress Trac]

#37217: get_network_by_path should use WP_Network_Query
----------------------------------------+-----------------------------
 Reporter:  spacedmonkey                |       Owner:  flixos90
     Type:  enhancement                 |      Status:  reviewing
 Priority:  normal                      |   Milestone:  Future Release
Component:  Networks and Sites          |     Version:  4.6
 Severity:  normal                      |  Resolution:
 Keywords:  has-patch needs-unit-tests  |     Focuses:  multisite
----------------------------------------+-----------------------------
Changes (by flixos90):

 * keywords:  has-patch needs-unit-tests needs-refresh => has-patch needs-
     unit-tests


Comment:

 [attachment:37217.2.diff] is a simplified patch that only replaces the
 database calls in `WP_Network::get_by_path()` by `get_networks()` calls.

 @jeremyfelt What do you have in mind for unit tests? There is
 `Tests_Multisite_Bootstrap::test_get_network_by_path()`, and I made sure
 these tests pass. Do we need further ones?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37217#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform