[wp-trac] [WordPress Trac] #38027: Comments feed returns invalid timestamp in http headers when there are no comments
WordPress Trac
noreply at wordpress.org
Thu Oct 6 19:09:28 UTC 2016
#38027: Comments feed returns invalid timestamp in http headers when there are no
comments
---------------------------------------------------+------------------
Reporter: dllh | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 4.7
Component: Comments | Version:
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests dev-feedback | Focuses:
---------------------------------------------------+------------------
Comment (by rachelbaker):
@swissspidy I am not very familiar with the comment feeds, but I have a
few thoughts:
1. In `_transition_comment_status()` you appear to only handle when a
comment becomes approved. What about when a comment changes from approved
to another status?
2. `_transition_comment_status()` isn't a specific name for what the
function does. As it is written in your latest patch the function flushes
the cache for comments when their status transitions. Maybe there is a
name that communicates this?
--
Ticket URL: <https://core.trac.wordpress.org/ticket/38027#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list