[wp-trac] [WordPress Trac] #31101: get_page_of_comment returns wrong page if comments are ordered with newest first

[WordPress Trac]

#31101: get_page_of_comment returns wrong page if comments are ordered with newest
first
-------------------------------------+--------------------------
 Reporter:  pajtai                   |       Owner:  rachelbaker
     Type:  defect (bug)             |      Status:  closed
 Priority:  normal                   |   Milestone:  4.7
Component:  Comments                 |     Version:  4.1
 Severity:  normal                   |  Resolution:  fixed
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+--------------------------
Changes (by rachelbaker):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 In [changeset:"38740"]:
 {{{
 #!CommitTicketReference repository="" revision="38740"
 Comments: Account for the `comment_order` option in
 `get_page_of_comment()`.

 Use the value of the `comment_order` setting to determine the date_query
 key to pass to `WP_Comment_Query`.
 Fixes a bug where sites that had comments ordered "newest" first would
 have the incorrect page number returned.

 Props tyxla, boonebgorges.
 Fixes #31101.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31101#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform