[wp-trac] [WordPress Trac] #36224: WP_Taxonomy class

[WordPress Trac]

#36224: WP_Taxonomy class
-------------------------------------------------+-------------------------
 Reporter:  swissspidy                           |       Owner:  swissspidy
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  4.7
Component:  Taxonomy                             |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests 4.7-early   |     Focuses:
  commit                                         |
-------------------------------------------------+-------------------------
Changes (by swissspidy):

 * keywords:  has-patch has-unit-tests dev-feedback 4.7-early => has-patch
     has-unit-tests 4.7-early commit


Comment:

 Replying to [comment:22 boonebgorges]:
 > > Mostly on twitter. tl;dr: final keyword, no interface, mutable, should
 use __get() and __set() instead of plenty of properties and set_props().
 >
 > It seems to me that the goal of this ticket, and the `WP_Post_Type`
 ticket, is to bring a small amount of sanity to what is currently a free-
 for-all `stdClass` fracas. We are not attempting to impose any actual OOP
 architecture. We *should* impose some architecture on it in the future,
 but it doesn't necessarily have to happen all at once, and I don't see
 that anything in the proposed patch affects our ability to do it down the
 road. Backward compatibility will probably always require that existing
 properties be mutable, whether or not they're hidden behind `__set()`. And
 `final` prevents us from having to make any decisions about the purpose
 and design of the interface for the time being.

 100% agreed.

 I uploaded [attachment:36224.5.diff] which makes the patch apply cleanly
 again. If there are no final objections I'd like to commit this. I can
 create new tickets for further improvements, just like the post type
 tickets I mentioned before.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36224#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform