[wp-trac] [WordPress Trac] #33704: Reduce reliance on wp_is_mobile()

WordPress Trac noreply at wordpress.org
Thu Oct 6 15:49:24 UTC 2016


#33704: Reduce reliance on wp_is_mobile()
-------------------------+-----------------------------
 Reporter:  johnbillion  |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  4.7
Component:  General      |     Version:  3.4
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:  ui, javascript
-------------------------+-----------------------------
Changes (by helen):

 * keywords:  needs-testing has-patch => has-patch


Comment:

 Agree that this should probably be broken out into discrete tasks. I like
 the login one - there may be cases where people are assuming there will be
 a `.mobile` class and are using it but I'm okay with breaking that for now
 (can always put it back if we absolutely have to) and it can easily be
 added back via filter anyway.

 The focus one is a little stranger to me in terms of what desired behavior
 truly is without considering what it currently does. I'm not sure why the
 width of a screen should be detected in JS in order to affect where
 initial focus is put, other than to recreate current functionality.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33704#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list