[wp-trac] [WordPress Trac] #36901: Removing wp_die() from wp_allow_comment()

[WordPress Trac]

#36901: Removing wp_die() from wp_allow_comment()
-------------------------------------------------+-------------------------
 Reporter:  websupporter                         |       Owner:
     Type:  enhancement                          |  rachelbaker
 Priority:  normal                               |      Status:  assigned
Component:  Comments                             |   Milestone:  4.7
 Severity:  normal                               |     Version:  4.6
 Keywords:  has-patch needs-testing has-unit-    |  Resolution:
  tests                                          |     Focuses:
-------------------------------------------------+-------------------------

Comment (by websupporter):

 I checked 36901.5 and it looks good to me. The typo mentioned by @mdgl is
 also fixed (sorry @mdgl, I was looking for a ticket concerning this
 problem, but I didn't find the one, where you were engaged in).

 I don't mind if we stick to `$avoid_die`. It's compelling to use
 `$wp_error = true` in order to get something like a standard but on the
 other hand for example in `wp_check_comment_flood()` we die or return
 `true`, so `$wp_error` would be misleading here and we would need another
 name. With `$avoid_die` we have one name running through the whole
 process. The name also focuses on what we want to do: avoid to die.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36901#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform