[wp-trac] [WordPress Trac] #37122: Error out when xml_create_parser is not available

WordPress Trac noreply at wordpress.org
Wed Oct 5 20:57:18 UTC 2016


#37122: Error out when xml_create_parser is not available
--------------------------+-----------------------
 Reporter:  kraftbj       |       Owner:  kraftbj
     Type:  defect (bug)  |      Status:  accepted
 Priority:  normal        |   Milestone:  4.7
Component:  XML-RPC       |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+-----------------------

Comment (by kraftbj):

 I updated the patch some:

 * src/wp-admin/link-parse-opml.php -- I kill processing using wp_die
 instead of the if/else structure. This file isn't called by Core,
 seemingly only called by the OPML Importer plugins (perhaps others).
 * src/wp-includes/feed.php - Confirming that the given return makes enough
 sense. We aren't able to confirm it is XML, so returning as a looser type
 should be fine. `prep_atom_text_construct()` doesn't seem to be called by
 Core either.
 * src/wp-includes/rss.php - I updated the error messages to be consistent
 with the others (and the php.net link isn't helpful for the PHP 7 issue).
 Previously, it called the parser while suppressing errors, then checking
 if it is a php resource. Changed it to be consistent with the other
 checks.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37122#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list