[wp-trac] [WordPress Trac] #34343: Customizer: Make panel headers sticky?

WordPress Trac noreply at wordpress.org
Tue Oct 4 20:32:17 UTC 2016

#34343: Customizer: Make panel headers sticky?
 Reporter:  pavelevap    |       Owner:  delawski
     Type:  enhancement  |      Status:  assigned
 Priority:  normal       |   Milestone:  4.7
Component:  Customize    |     Version:  4.3
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:  ui, javascript
Changes (by delawski):

 * keywords:  ux-feedback needs-patch => has-patch


 [https://core.trac.wordpress.org/attachment/ticket/34343/34343_2.diff The
 patch] is ready for review and testing. Here's the PR:

 I have tested it in IE 9, 10, 11, Firefox and Chrome. It worked well in
 each case for me, but I'd really appreciate more testing.

 The only downside of the patch is that it is infeasible to make the 'main'
 header element ('You are customizing...') sticky in current
 implementation. In opposite to all other headers, the 'main' header
 element (`div#customize-info`) is outside of the actual UL list containing
 links to top-level panels/sections (`ul.customize-pane-parent`). Because
 of that, it is CSS-transformed separately along with `ul.customize-pane-
 parent`. It would be suboptimal to write separate 'sticking/sliding'
 routines for this single element only.

 Instead I'd suggest changing the 'main' panel markup so that the header
 `div#customize-info` is moved to the `ul.customize-pane-parent` to match
 other panes. I think that if the `id` and `class` are kept intact, the
 change wouldn't have a negative impact on the customizer sidebar. However,
 it should be described in a separate ticket and my patch doesn't account
 for that.

Ticket URL: <https://core.trac.wordpress.org/ticket/34343#comment:25>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list