[wp-trac] [WordPress Trac] #37817: Emoji code not loaded responsibly
WordPress Trac
noreply at wordpress.org
Mon Oct 3 23:05:29 UTC 2016
#37817: Emoji code not loaded responsibly
---------------------------+--------------------------
Reporter: superpoincare | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 4.7
Component: Emoji | Version: 4.6
Severity: normal | Resolution:
Keywords: needs-patch | Focuses: performance
---------------------------+--------------------------
Comment (by pento):
I'm fine with dropping the `simple` and `unicode8` tests.
* `flag`: I'm inclined to leave it as a test of both pride flag and
country flag. While they're both flags, their implementation is different
(white flag + ZWJ + rainbow vs regional indicator letter + regional
indicator letter). I recall there being problems in the past of platforms
adding everything except country flags.
* `unicode9`: Leave as is.
* `diversity`: Leave as is, there are still issues with platforms not
implementing diversity.
To avoid blocking the DOM more than we have to, I wonder if it's worth
creating the canvas element once, instead of every time
`browserSupportsEmoji()` is called?
Also, the test happens as early as possible, so that it avoids running
after the page CSS has been parsed. The CSS reflow it can cause only gets
more expensive the later it runs. I would be quite cautious about waiting
until `window.load` to run the test.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/37817#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list