[wp-trac] [WordPress Trac] #18375: Post type templates

WordPress Trac noreply at wordpress.org
Sat Oct 1 22:57:43 UTC 2016


#18375: Post type templates
--------------------------------------+-----------------------
 Reporter:  johnbillion               |       Owner:
     Type:  enhancement               |      Status:  new
 Priority:  normal                    |   Milestone:  4.7
Component:  Posts, Post Types         |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:  template
--------------------------------------+-----------------------

Comment (by WPDevHQ):

 Replying to [comment:34 Mte90]:
 > The difference respect `18375.diff`:
 >
 > * Now use get_file_data to check and get the value for Template Name and
 for Template Type
 > * Not use the labels->attributes but use the old code to print Page
 Attributes/Attributes as explained on
 https://core.trac.wordpress.org/ticket/18375#comment:32
 >
 >>In the diff there seems to be a revertion for wp-admin/edit-form-
 advanced.php
 {{{
 +if ( post_type_supports( $post_type, 'page-attributes' ) ) {
 +       add_meta_box( 'pageparentdiv', 'page' == $post_type ? __('Page
 Attributes') : __('Attributes'), 'page_attributes_meta_box', null, 'side',
 'core' );
 +}
 }}}
 Shouldn't that be
 {{{
 +if ( post_type_supports( $post_type, 'page-attributes' ) ) {
 +       add_meta_box( 'pageparentdiv',
 $post_type_object->labels->attributes, 'page_attributes_meta_box', null,
 'side', 'core' );
 +}
 }}}
 Not checked further

--
Ticket URL: <https://core.trac.wordpress.org/ticket/18375#comment:35>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list