[wp-trac] [WordPress Trac] #37746: Replace `absint( $meta_id)` check in `delete_metadata_by_mid`, etc

WordPress Trac noreply at wordpress.org
Sat Oct 1 06:27:30 UTC 2016


#37746: Replace `absint( $meta_id)` check in `delete_metadata_by_mid`, etc
--------------------------------------+----------------------------
 Reporter:  peterwilsoncc             |       Owner:  peterwilsoncc
     Type:  defect (bug)              |      Status:  closed
 Priority:  normal                    |   Milestone:  4.7
Component:  Options, Meta APIs        |     Version:  4.0
 Severity:  normal                    |  Resolution:  fixed
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+----------------------------
Changes (by peterwilsoncc):

 * owner:   => peterwilsoncc
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"38699"]:
 {{{
 #!CommitTicketReference repository="" revision="38699"
 Meta: Improve ID casting when getting, updating or deleting meta data.

 Blindly casting IDs to absolute integers in `get_metadata_by_mid()`,
 `update_metadata_by_mid()` and `delete_metadata_by_mid()` can cause
 unexpected behaviour when a floating or negative number is passed.

 Fixes #37746.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37746#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list