[wp-trac] [WordPress Trac] #36824: do_all_pings function queries all posts

[WordPress Trac]

#36824: do_all_pings function queries all posts
------------------------------+-----------------------------
 Reporter:  spacedmonkey      |       Owner:  boonebgorges
     Type:  enhancement       |      Status:  reviewing
 Priority:  normal            |   Milestone:  Future Release
Component:  Pings/Trackbacks  |     Version:  2.1
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |     Focuses:  performance
------------------------------+-----------------------------

Comment (by dshanske):

 @boonebgorges The original 'all' would not cover custom post types that
 were listed as 'exclude_from_search'. There are a few tickets that have
 covered that issue. I discovered when I implemented the code in a test
 plugin that it was an issue. But publicly_queryable would indicate it
 would be accessible from the front end even if not displayed by default,
 which would be consistent with the idea that pingback is to notify that
 you've linked to someone.

 The pingback function in WordPress adds its URLs to the pinged field in
 the post so that it won't send a trackback and a pingback. The reason why
 I wanted to break that portion away is that I wanted to change the
 do_trackbacks and the pingback functions, get_punged, get_pinged, etc to
 support passing either a post_ID or a post object, which is an easy
 change.

 There are a few other minor issues(such as the items removed from the
 to_ping list wouldn't update the post object, but this would reduce the
 number of queries in this area to the list of known recently updated posts
 where the to_ping list has already been retrieved.

 So, based on your original feedback, this is something worth taking away
 to look at in a different way.

 Re trackbacks not being sent if pingbacks were...since one is a manual
 process and the other an automatic one, question is if this makes sense.
 But that is a bigger issue.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36824#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform