[wp-trac] [WordPress Trac] #37103: get_comments_number_text() should not replace '%' in post title
WordPress Trac
noreply at wordpress.org
Wed Nov 30 17:12:25 UTC 2016
#37103: get_comments_number_text() should not replace '%' in post title
--------------------------------------+-----------------------------
Reporter: SergeyBiryukov | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Future Release
Component: Comments | Version: 4.2
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests | Focuses:
--------------------------------------+-----------------------------
Comment (by keesiemeijer):
In [attachment:37103.patch] the `%` character is replaced by `__PERCENT__`
in post titles for posts with more than 1 comment. After the comment
number replacement is done it's replaced back to `%`.
I didn't remove this
[https://core.trac.wordpress.org/browser/tags/4.6.1/tests/phpunit/tests/comment/template.php#L109
unit test] as it's (I think) the default behavior for
`get_comments_number_text()`. Maybe we should remove the comment though.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/37103#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list