[wp-trac] [WordPress Trac] #38987: Twenty Seventeen: Use of wrong function when escaping font url
WordPress Trac
noreply at wordpress.org
Wed Nov 30 10:06:51 UTC 2016
#38987: Twenty Seventeen: Use of wrong function when escaping font url
----------------------------------+--------------------
Reporter: davidakennedy | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 4.7
Component: Bundled Theme | Version: trunk
Severity: normal | Resolution:
Keywords: good-first-bug close | Focuses:
----------------------------------+--------------------
Changes (by ocean90):
* keywords: good-first-bug => good-first-bug close
Comment:
I think the `esc_url_raw()` is appropriate here because
`twentyseventeen_fonts_url()` only returns the URL, it doesn't print it.
The value is currently passed to `wp_enqueue_style()` which uses
`esc_url()` internally in `WP_Styles::_css_href()`.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/38987#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list