[wp-trac] [WordPress Trac] #38952: Customize Menus: screen options are broken

[WordPress Trac]

#38952: Customize Menus: screen options are broken
-------------------------------------------+--------------------------
 Reporter:  celloexpressions               |       Owner:  westonruter
     Type:  defect (bug)                   |      Status:  accepted
 Priority:  normal                         |   Milestone:  4.7
Component:  Customize                      |     Version:  trunk
 Severity:  major                          |  Resolution:
 Keywords:  has-patch commit dev-feedback  |     Focuses:
-------------------------------------------+--------------------------
Changes (by westonruter):

 * keywords:  has-patch commit => has-patch commit dev-feedback


Comment:

 [attachment:38952.2.diff] updates the jsdoc comment on `MenusPanel#ready`.

 In regards to efficiency of adding event listeners to all the active field
 toggles: there are only 5 toggles. Adding 5 event listeners for each nav
 menu is going to add an insignificant amount of event listeners  overall,
 even with 10 separate menus there would only be 50 event listeners. I
 would be worried if we were getting into 500 or 5000 event listeners.
 Eventually it would be better to have `Value` states for the checkboxes
 with a single event handler added from the panel, with the event listeners
 on `Value` added in the sections. But that was too much for RC I think.

 +1 for commit. Needs `dev-reviewed`.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38952#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform