[wp-trac] [WordPress Trac] #38268: WP_Comment_Query Pagination
WordPress Trac
noreply at wordpress.org
Sun Nov 27 15:40:45 UTC 2016
#38268: WP_Comment_Query Pagination
----------------------------------------+-----------------------------
Reporter: wordpresssites | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Future Release
Component: Comments | Version: trunk
Severity: normal | Resolution:
Keywords: needs-patch good-first-bug | Focuses:
----------------------------------------+-----------------------------
Comment (by AdamWills):
In the patch, I used the same logic used in WP_User_Query - a valid (>0)
offset value exists, it will override the paged parameter. Unit tests are
attached.
Replying to [comment:4 boonebgorges]:
> I think we'd probably be happy to consider pagination parameters. As you
note, they add convenience for many use cases.
>
> Note that a patch for this feature ought to have tests that demonstrate
how the new params work alongside `number` and `offset` - one set of
params will have to "win" when both are provided.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/38268#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list