[wp-trac] [WordPress Trac] #38945: Menu customizer : adding a term item to a menu creates a fatal error when previewing the changeset

[WordPress Trac]

#38945: Menu customizer : adding a term item to a menu creates a fatal error when
previewing the changeset
---------------------------------------------+--------------------------
 Reporter:  nikeo                            |       Owner:  westonruter
     Type:  defect (bug)                     |      Status:  closed
 Priority:  normal                           |   Milestone:  4.7
Component:  Customize                        |     Version:  trunk
 Severity:  normal                           |  Resolution:  fixed
 Keywords:  has-patch has-unit-tests commit  |     Focuses:
---------------------------------------------+--------------------------
Changes (by westonruter):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 In [changeset:"39365"]:
 {{{
 #!CommitTicketReference repository="" revision="39365"
 Customize: Fix logic for previewing the URL for `nav_menu_item` settings
 for terms and post type archives.

 Fixes typo in args passed to `get_term_link()` which caused a fatal error
 due to this call returning a `WP_Error` which was set to `url`. Also fixes
 never-satisfiable condition for obtaining post type archive URL. Also
 ensures that `WP_Error` never leaks through as `url` by setting it to an
 empty string. Adds missing unit tests.

 Amends [38991].
 See #38114.
 Fixes #38945.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38945#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform