[wp-trac] [WordPress Trac] #38950: Twenty Seventeen: 1px of header video is visible at bottom of page

[WordPress Trac]

#38950: Twenty Seventeen: 1px of header video is visible at bottom of page
-------------------------------------------------+-------------------------
 Reporter:  celloexpressions                     |       Owner:  joemcgill
     Type:  defect (bug)                         |      Status:  accepted
 Priority:  normal                               |   Milestone:  4.7
Component:  Bundled Theme                        |     Version:  trunk
 Severity:  minor                                |  Resolution:
 Keywords:  has-screenshots has-patch needs-     |     Focuses:
  testing                                        |
-------------------------------------------------+-------------------------
Changes (by joemcgill):

 * keywords:  needs-patch has-screenshots => has-screenshots has-patch
     needs-testing
 * owner:   => joemcgill
 * status:  new => accepted
 * milestone:  Awaiting Review => 4.7


Comment:

 I think this might be a browser rounding issue due to using relative sizes
 for line-heights and margins within the Twenty Seventeen theme. This can
 result in the outer `#page` container calculated to a non-integer
 height—leaving a little overlap where the fixed height video sticks out at
 the bottom. Adding 1px of padding to the bottom of the header, seems to
 clear this up.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38950#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform