[wp-trac] [WordPress Trac] #38946: WP_Upgrader: Protection against deleting files in destination directory

[WordPress Trac]

#38946: WP_Upgrader: Protection against deleting files in destination directory
-----------------------------+------------------------------
 Reporter:  shivapoudel      |       Owner:
     Type:  enhancement      |      Status:  new
 Priority:  normal           |   Milestone:  Awaiting Review
Component:  Upgrade/Install  |     Version:
 Severity:  normal           |  Resolution:
 Keywords:                   |     Focuses:
-----------------------------+------------------------------

Comment (by dd32):

 @shivapoudel Wouldn't it be possible to simply include the subdirectory
 in the `destination` arg?

 That being said, having some way of triggering this specific code check
 for others, either through a filter or a parameter sounds like a good
 idea.

 Would you be able to
 [https://make.wordpress.org/core/handbook/tutorials/trac/submitting-a-patch/
 attach your changes as a `diff` file] rather than the entire file? Please
 also make sure that any args added have defaults set correctly too.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38946#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform