[wp-trac] [WordPress Trac] #38945: Menu customizer : adding a term item to a menu creates a fatal error when previewing the changeset

[WordPress Trac]

#38945: Menu customizer : adding a term item to a menu creates a fatal error when
previewing the changeset
----------------------------------------+--------------------------
 Reporter:  nikeo                       |       Owner:  westonruter
     Type:  defect (bug)                |      Status:  accepted
 Priority:  normal                      |   Milestone:  4.7
Component:  Customize                   |     Version:  trunk
 Severity:  normal                      |  Resolution:
 Keywords:  has-patch needs-unit-tests  |     Focuses:
----------------------------------------+--------------------------
Changes (by westonruter):

 * keywords:   => has-patch needs-unit-tests
 * owner:   => westonruter
 * status:  new => accepted
 * milestone:  Awaiting Review => 4.7


Comment:

 @nikeo great catch! This was introduced in r38991 as part of #38114 in the
 `\WP_Customize_Nav_Menu_Item_Setting::value_as_wp_post_nav_menu_item()`
 method to ensure nav menu item URL is set according to linked object.
 There was a typo in how in that it was passing `object` instead of
 `object_id` into `get_term_link()`. Please give [attachment:38945.0.diff]
 a try.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38945#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform