[wp-trac] [WordPress Trac] #38929: WP_Hook should support filters added manually through `advanced-cache.php`
WordPress Trac
noreply at wordpress.org
Thu Nov 24 12:38:40 UTC 2016
#38929: WP_Hook should support filters added manually through `advanced-cache.php`
--------------------------+------------------
Reporter: dd32 | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 4.7
Component: Plugins | Version:
Severity: normal | Resolution:
Keywords: | Focuses:
--------------------------+------------------
Comment (by dd32):
As noted in slack, I'll also mention that there's the possibility we
could've simply used a new variable `$wp_filter_hooks` (for example) and
migrated added hooks over as needed (instead of calling
`WP_Hook::build_preinitialized_hooks()`) - this would've have the ability
of avoiding any lost hooks and fatal errors, but while having all our
public API's continue to work.
I can't really see any downside to that, but given the lack of bug reports
during 4.7, and the ability to support the most common example I can think
of (Batcache) through [attachment:38929.diff] I don't see the need to
explore that option further at this point - anyone modifying `$wp_filter`
directly shouldn't probably be doing so anyway after WordPress loads.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/38929#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list