[wp-trac] [WordPress Trac] #38342: Quick Draft: Leverage REST API endpoints

[WordPress Trac]

#38342: Quick Draft: Leverage REST API endpoints
-------------------------------------+-------------------------------------
 Reporter:  adamsilverstein          |       Owner:  joehoyle
     Type:  enhancement              |      Status:  assigned
 Priority:  normal                   |   Milestone:  Future Release
Component:  Administration           |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch 4.8-early      |     Focuses:  accessibility,
  needs-unit-tests                   |  javascript, rest-api
-------------------------------------+-------------------------------------

Comment (by joehoyle):

 In 14:

 > <?php esc_html_e( 'Drafts' ) ?> and <?php esc_html_e( 'Loading…' ) ?>
 should be without esc_html(), the latter should use ….

 Fixed, my bad - I usually escape translations.

 > grunt precommit:js complains about a missing var declaration: 'date' is
 not defined.

 Fixed up warnings here.

 > grunt precommit:css generates the missing vendor prefixes for the
 animation, make sure to run that before the commit.

 I ran it in the patch too, to make sure.

 > The currently title is a number because of
 attributes.title.rendered.length.

 Doh, fixed!

 > JS variables in script-loader.php should be camelCase, no_title =>
 noTitle.

 Fixed

 Still need to do:

 1. While we're here: To improve a11y we should probably make use of
 wp.a11y.speak().
 1. Can we have some QUnit tests for wp.formatting.trimWords()?
 1. The View All links is displayed if the collection has more than one
 drafts
 1. The error notice (https://cloudup.com/cX88Fx1mGrr) should use the
 alternative style

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38342#comment:65>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform