[wp-trac] [WordPress Trac] #30599: media views: improve keyboard accessibility avoiding confusing tab stops

[WordPress Trac]

#30599: media views: improve keyboard accessibility avoiding confusing tab stops
-------------------------------------------------+-------------------------
 Reporter:  afercia                              |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  4.8
Component:  Media                                |     Version:  4.0
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-screenshots needs-     |     Focuses:  ui,
  refresh                                        |  accessibility
-------------------------------------------------+-------------------------
Changes (by afercia):

 * keywords:  has-patch => has-patch has-screenshots needs-refresh
 * milestone:  Future Release => 4.8


Comment:

 Looking back at this, can still reproduce it. Edit a post, click "Add
 Media", select an image and click on "Edit Image" in the right sidebar:
 the `media-frame-menu` is there on the left with all its links, just
 hidden out of view. Using the keyboard, each link is a hidden tab stop.
 Screen readers can still access the links and activate them:

 [[Image(https://cldup.com/5ObQ3Khn4N.jpg)]]

 Researched a bit for the `.media-frame-toolbar` case, and seems to me it's
 only used for back compatibility with plugins that still use Thickbox and
 the old upload method. Not 100% sure this back compatibility hack still
 works. By the way, it's intended to display thickbox inside an iframe
 inside the modal and the bottom toolbar gets hidden out of view with
 `bottom: -61px`:

 [[Image(https://cldup.com/Ow7tN39Zwa.png)]]

 I think it can be safely hidden with `display: none` so
 [attachment:30599.3.patch] looks good to me, just needs a refresh.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30599#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform