[wp-trac] [WordPress Trac] #38865: Customize: Setting validation error messages can fail to clear if newly-supplied valid value matches previously-valid value stored in changeset

WordPress Trac noreply at wordpress.org
Sat Nov 19 22:38:43 UTC 2016


#38865: Customize: Setting validation error messages can fail to clear if newly-
supplied valid value matches previously-valid value stored in changeset
--------------------------+--------------------------
 Reporter:  westonruter   |       Owner:  westonruter
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:  4.7
Component:  Customize     |     Version:
 Severity:  normal        |  Resolution:  fixed
 Keywords:  has-patch     |     Focuses:
--------------------------+--------------------------
Changes (by westonruter):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 In [changeset:"39320"]:
 {{{
 #!CommitTicketReference repository="" revision="39320"
 Customize: Ensure that `WP_Customize_Manager::save_changeset_post()`
 returns `setting_validities` even for supplied values that are unchanged
 from values in changeset.

 Check setting existence and authorization via
 `WP_Customize_Manager::validate_setting_values()` even for `null` values
 to account for custom params being added to settings, preventing failures
 from being silently ignored.

 See #38705, #30937.
 Fixes #38865.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38865#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list