[wp-trac] [WordPress Trac] #38864: Customize: Settings of custom types should return post_value when value() called

[WordPress Trac]

#38864: Customize: Settings of custom types should return post_value when value()
called
--------------------------+------------------
 Reporter:  westonruter   |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.7
Component:  Customize     |     Version:
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:
--------------------------+------------------
Description changed by westonruter:

Old description:

> When a custom setting `type` is supplied when constructing a the base
> `WP_Customize_Setting` class, then the plugin implementing the custom
> type is expected to supply the value via the `customize_value_{$id_base}`
> filter which is then returned in the call to
> `WP_Customize_Setting::value()`. When a setting is previewed, however, it
> is expected that the `WP_Customize_Setting::value()` returns the
> previewed (post) value instead of whatever the
> `customize_value_{$id_base}` filter returned. This is not currently the
> case.

New description:

 When a custom setting `type` is supplied when constructing a the base
 `WP_Customize_Setting` class, then the plugin implementing the custom type
 is expected to supply the value via the `customize_value_{$id_base}`
 filter which is then returned in the call to
 `WP_Customize_Setting::value()`. When a setting is previewed, however, it
 is expected that the `WP_Customize_Setting::value()` returns the previewed
 (post) value instead of whatever the `customize_value_{$id_base}` filter
 returned. This is not currently the case.

 This issue is clearly seen when adding a setting via code like:

 {{{#!php
 <?php
 $wp_customize->add_setting( 'test_number', array(
         'type' => 'demo',
 ) );
 }}}

 When loading the customizer and supplying a value for that setting, if you
 then try to reload the customizer so that the stored changeset restores
 the customized state upon reload, you'll see that the input is
 unexpectedly empty.

--

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38864#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform