[wp-trac] [WordPress Trac] #38615: Round out and refine starter content

[WordPress Trac]

#38615: Round out and refine starter content
-------------------------------------+------------------
 Reporter:  helen                    |       Owner:
     Type:  task (blessed)           |      Status:  new
 Priority:  high                     |   Milestone:  4.7
Component:  Themes                   |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+------------------
Changes (by helen):

 * keywords:   => has-patch needs-testing


Comment:

 [attachment:38615.9.diff] is ready for testing. To test, you will need:

 * These images in `twentyseventeen/assets/images`: http://s.hyhs.me/iAFm
 * To set the `fresh_site` option to `1` (if you are a wp-cli user, `wp
 option set fresh_site 1`).
 * Load up the customizer and see something that hopefully looks like this
 (except with the default header image): http://s.hyhs.me/iAfl

 What this patch should get you is featured images set for each of those
 pages that are homepage sections. These attachments are sideloaded from
 within the theme directory and are set to `auto-draft` so they don't
 appear in the media library until you save your changes; otherwise, they
 should stay hidden and later be garbage collected. It also happens to
 enable page templates to be set; to test that, you will want to make a
 page template inside the `twentyseventeen` directory and add `'template'
 => 'sample-page-template.php'` (or whatever the filename is) to one of the
 non-blog page/post definitions in `functions.php`.

 I'm interested in:

 * Does this help present Twenty Seventeen in a better way upon first live
 preview? Do you see this being useful for other themes that use image
 attachments in various contexts (the ID can be used for theme mods and
 more, not just the post thumbnail)?
 * How does the load time feel? This is a concern because of the image
 sideloading. Themes should be encouraged not to add too many attachments
 this way, both for load reasons and not to bloat theme packages too much.
 * Does everything save correctly? In particular, do those sideloaded
 images only appear in the media library after you've saved and published
 your customizer changes?
 * Is enabling `auto-draft` for attachments a problem? Does the garbage
 collection work?
 * What do you think of the patch in general?
 * Are there any bugs?

 And finally, if this is the first time you're taking a look at starter
 content, are there any changes or additions you'd want to see in the other
 defined content?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38615#comment:27>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform