[wp-trac] [WordPress Trac] #38847: Twenty Seventeen: Header Image used is smaller than 2000x1200px
WordPress Trac
noreply at wordpress.org
Fri Nov 18 04:27:24 UTC 2016
#38847: Twenty Seventeen: Header Image used is smaller than 2000x1200px
---------------------------+------------------------
Reporter: transl8or | Owner: joemcgill
Type: defect (bug) | Status: accepted
Priority: normal | Milestone: 4.7
Component: Bundled Theme | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch | Focuses: ui
---------------------------+------------------------
Changes (by joemcgill):
* keywords: => has-patch
* owner: => joemcgill
* status: new => accepted
* milestone: Awaiting Review => 4.7
Comment:
Hi @transl8or – thanks for the report!
This looks to be an issue of the `sizes` attribute being calculated
incorrectly, resulting in the browser downloading the wrong resource.
[attachment:38847.diff] adds a filter to the markup generated by
`get_header_image_tag()` to correct this problem.
Before the filter, the `img` contained:
`sizes="(max-width: 767px) 89vw, (max-width: 1000px) 54vw, (max-width:
1071px) 543px, 580px"`
And after:
`sizes="100vw"`
--
Ticket URL: <https://core.trac.wordpress.org/ticket/38847#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list