[wp-trac] [WordPress Trac] #38808: Merge similar translation strings in WordPress 4.7

WordPress Trac noreply at wordpress.org
Thu Nov 17 15:38:09 UTC 2016


#38808: Merge similar translation strings in WordPress 4.7
------------------------------+--------------------
 Reporter:  ramiy             |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  4.7
Component:  Text Changes      |     Version:  trunk
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:
------------------------------+--------------------
Changes (by SergeyBiryukov):

 * keywords:  has-patch => has-patch commit
 * milestone:  Awaiting Review => 4.7


Comment:

 @ramiy, thank you for the patches! Here's my review:

 * [attachment:38808-welcome.patch]: The non-breaking space is required to
 prevent wrapping on About page.
 * [attachment:38808-sticky.patch]: Looks good, we're not checking a
 particular post here.
 * [attachment:38808-assign-terms.patch]: The existing strings are more
 accurate, there's a difference between assigning terms in general,
 assigning a particular term, and assigning several terms in a single
 request.
 * [attachment:38808-invalid.patch]: Mostly looks good, I've found a few
 more instances that could be adjusted for consistency.
 * [attachment:38808-search-results.patch]: That strings is used for title
 and should be capitalized.
 * [attachment:38808-delete-resource.patch]: Looks good.
 * [attachment:38808-no-results.patch]: Looks good.
 * [attachment:38808-updating.patch]: The existing string seems correct.
 * [attachment:38808-allow-comments.patch]: Strings in
 `wp_xmlrpc_server::initialise_blog_option_info()` don't have a full stop,
 while strings in `register_initial_settings()` do have one. They could
 probably be merged or updated, but let's create a separate ticket for
 that.
 * [attachment:38808-delete-post.patch]: Looks good, we're checking a
 particular post here.

 [attachment:38808.combined.patch] is my take on the changes.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38808#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list