[wp-trac] [WordPress Trac] #38818: REST API: Support ipv6 for `author_ip` in comments endpoint

WordPress Trac noreply at wordpress.org
Thu Nov 17 12:23:07 UTC 2016


#38818: REST API: Support ipv6 for `author_ip` in comments endpoint
-------------------------------------------------+-------------------------
 Reporter:  dd32                                 |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  4.7
Component:  Comments                             |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests needs-      |     Focuses:  rest-api
  testing needs-refresh                          |
-------------------------------------------------+-------------------------

Comment (by dd32):

 > Having a format string that is called ipv4 but does something else
 related to IP addresses is not sane.

 When you phrase it like that, I agree, but validating as `ip` is better
 than not validating at all, especially when the ''intent'' of setting it
 to `ipv4` is to validate as an IP. Sane validators for the future is a
 better solution than adding a validator for something that's hopefully
 soon going to be a thing of the past, ease the transition forward.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38818#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list