[wp-trac] [WordPress Trac] #38678: Video Headers: Improve Basic Accessibility

[WordPress Trac]

#38678: Video Headers: Improve Basic Accessibility
------------------------------------+----------------------------
 Reporter:  davidakennedy           |       Owner:  joemcgill
     Type:  defect (bug)            |      Status:  assigned
 Priority:  normal                  |   Milestone:  4.7
Component:  Themes                  |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:  accessibility
------------------------------------+----------------------------

Comment (by afercia):

 Replying to [comment:44 joemcgill]:
 > [attachment:38678.11.diff] adds support for `wp.a11y.speak()`
 Nice addition, well doe :) Tested with Safari + VoiceOver and Firefox +
 NVDA, looks good to me.

 Not strictly related, on the JavaScript side there are 4 cases of use of
 `wp` that I'd suggest to double check. Technically, `wp` at that point is
 undefined and jshint doesn't throw errors just because `wp` is listed as
 "global" in `.jshintrc`. But to be sure the wp object exists, shouldn't it
 be set on top of the file and then the calls be `window.wp ...` ?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38678#comment:45>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform