[wp-trac] [WordPress Trac] #38594: pdf preview sizes not filterable
WordPress Trac
noreply at wordpress.org
Tue Nov 15 04:24:11 UTC 2016
#38594: pdf preview sizes not filterable
-----------------------------------+------------------------
Reporter: nosilver4u | Owner: joemcgill
Type: enhancement | Status: accepted
Priority: normal | Milestone: 4.7
Component: Media | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch 2nd-opinion | Focuses:
-----------------------------------+------------------------
Changes (by joemcgill):
* keywords: has-patch commit => has-patch 2nd-opinion
Comment:
[attachment:38594.2.diff] modifies the fallback logic so the
`fallback_intermediate_image_sizes` filter could be used to short circuit
loading PDFs into an image editor if no fallback sizes have been defined.
However, a downside to this approach is potentially limiting folks who
want to generate the full size but not any intermediate sizes as
@mikeschroder mentioned in our [https://wordpress.slack.com/archives/core-
media/p1478884115000137 discussion on Slack]. I'm not convinced we need to
add an extra filter to support that use case, since someone could create
approximation of a full size if they needed to using this same filter.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/38594#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list