[wp-trac] [WordPress Trac] #38778: Only show video header controls if previewing front page

[WordPress Trac]

#38778: Only show video header controls if previewing front page
--------------------------+------------------
 Reporter:  westonruter   |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.7
Component:  Customize     |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+------------------

Comment (by joemcgill):

 @westonruter in [attachment:38778.1.diff], I like the wording but the use
 of the `\261E` seems out of character for WP. I don't think we use that
 pattern anywhere else. What if we showed that message inside a customizer
 notice instead? [attachment:38778.diff] is a quick riff on what that might
 look like.

 [[Image(https://cldup.com/_m_v2yjJVf.thumb.png)]]

 The only other decision I think we need to land on is what the name of the
 callback should be. Re: my earlier comment –

 > I think the name should include the word "video" somehow unless the
 callback could be used to deactivate header image support on certain pages
 as well.

 Should we build in future compatibility for needing to use the active
 callback for more than checking video support? If not, then I think we
 should use the name `video_active_callback` as proposed in
 [https://core.trac.wordpress.org/attachment/ticket/38738/38738.7.diff
 38738.7.diff].

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38778#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform