[wp-trac] [WordPress Trac] #38738: Remove front page restrictions from new custom header functions

[WordPress Trac]

#38738: Remove front page restrictions from new custom header functions
--------------------------------------------------+--------------------
 Reporter:  peterwilsoncc                         |       Owner:
     Type:  defect (bug)                          |      Status:  new
 Priority:  normal                                |   Milestone:  4.7
Component:  Themes                                |     Version:  trunk
 Severity:  normal                                |  Resolution:
 Keywords:  has-patch has-unit-tests 2nd-opinion  |     Focuses:
--------------------------------------------------+--------------------

Comment (by flixos90):

 Replying to [comment:23 bradyvercher]:
 > It wasn't readily apparent with the tests in [attachment:38738.5.diff]
 since they're only testing new video arguments, but they still poisoned
 subsequent tests. Backing up the global and restoring doesn't fix the
 issue and shouldn't be necessary.

 The tests [attachment:38738.6.diff] are looking great to me. Sorry I
 somehow overlooked the constants being defined. Regarding the global
 though, I think we should make sure it is reset to its original value
 afterwards, I think this should be the case in any unit tests where a
 global is modified as this can also poison subsequent tests.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38738#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform