[wp-trac] [WordPress Trac] #37997: Increase in function calls to get_locale() because of _load_textdomain_just_in_time()

WordPress Trac noreply at wordpress.org
Mon Nov 14 20:09:44 UTC 2016


#37997: Increase in function calls to get_locale() because of
_load_textdomain_just_in_time()
-------------------------------------------------+-------------------------
 Reporter:  sharkomatic                          |       Owner:  ocean90
     Type:  defect (bug)                         |      Status:  reviewing
 Priority:  normal                               |   Milestone:  4.7
Component:  I18N                                 |     Version:  4.6
 Severity:  normal                               |  Resolution:
 Keywords:  needs-testing has-patch needs-unit-  |     Focuses:
  tests                                          |  performance
-------------------------------------------------+-------------------------
Changes (by ocean90):

 * keywords:  needs-testing has-patch has-unit-tests => needs-testing has-
     patch needs-unit-tests


Comment:

 Thanks @jrf! [attachment:trac-37997-improve-just-in-time-
 performance.patch] looks good on a first glance. I think we just need to
 find some better names for the functions. :)  We could probably merge
 `_get_path_to_glotpress_translation()`  into `_get_path_to_translation()`
 but I get the single responsibility idea.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37997#comment:26>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list