[wp-trac] [WordPress Trac] #38697: Twenty Seventeen: Video header pause button design
WordPress Trac
noreply at wordpress.org
Mon Nov 14 16:53:25 UTC 2016
#38697: Twenty Seventeen: Video header pause button design
------------------------------------+------------------------
Reporter: melchoyce | Owner: joemcgill
Type: enhancement | Status: assigned
Priority: normal | Milestone: 4.7
Component: Bundled Theme | Version:
Severity: normal | Resolution:
Keywords: has-patch dev-feedback | Focuses:
------------------------------------+------------------------
Comment (by joemcgill):
> If the color of the SVG icons doesn't need to be changed, they can be
used as background images. I don't think the extra accessibility markup is
needed since that's provided by the button text.
I was thinking the same thing. I'm not sure the actual SVGs need to be
injected into the button, however, we could potentially add the button
markup as a template file that is filterable, but that will require us to
add logic to the custom header JS for template rendering. We could also
move the logic for creating the buttons out of the initialization method
so it could be replaced by a custom handler (which might be the best
option).
--
Ticket URL: <https://core.trac.wordpress.org/ticket/38697#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list