[wp-trac] [WordPress Trac] #38697: Twenty Seventeen: Video header pause button design

[WordPress Trac]

#38697: Twenty Seventeen: Video header pause button design
---------------------------+------------------------
 Reporter:  melchoyce      |       Owner:  joemcgill
     Type:  enhancement    |      Status:  assigned
 Priority:  normal         |   Milestone:  4.7
Component:  Bundled Theme  |     Version:
 Severity:  normal         |  Resolution:
 Keywords:  needs-patch    |     Focuses:
---------------------------+------------------------

Comment (by laurelfulford):

 Made a second attempt in [attachment:38697.2.diff]. I originally
 overcomplicated how the SVGs needed to be added, so have reduced the
 markup/styles.

 I noticed on further testing that the button wasn't always loaded in time
 with the `wp-custom-header-video-loaded` event. I've added a `setTimeout`
 to make sure the button is present before injecting the SVG - it gets the
 job done, but it's not great. Suggestions for improvements are very
 welcome!

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38697#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform