[wp-trac] [WordPress Trac] #29785: User count not correct

[WordPress Trac]

#29785: User count not correct
-------------------------------------------------+-------------------------
 Reporter:  psoluch                              |       Owner:
     Type:  defect (bug)                         |  boonebgorges
 Priority:  normal                               |      Status:  assigned
Component:  Users                                |   Milestone:  Future
 Severity:  normal                               |  Release
 Keywords:  good-first-bug has-unit-tests has-   |     Version:
  patch needs-testing                            |  Resolution:
                                                 |     Focuses:
                                                 |  performance
-------------------------------------------------+-------------------------
Changes (by johnbillion):

 * keywords:  good-first-bug has-unit-tests has-patch => good-first-bug has-
     unit-tests has-patch needs-testing


Comment:

 [attachment:29785.4.diff] improves the tests by implementing the existing
 `data_count_users_strategies` data provider.

 This patch looks good, but as @psoluch mentioned it will need performance
 testing (before and after) with a large number of users in place so the
 effect on performance can be seen. The `wp_users.ID` field is indexed, and
 by its nature the `wp_users` table contains much fewer rows than
 `wp_usermeta` so its affect should only be slight.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29785#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform