[wp-trac] [WordPress Trac] #38755: Customize: use calc() to set textarea height for custom CSS

WordPress Trac noreply at wordpress.org
Sat Nov 12 03:32:29 UTC 2016


#38755: Customize: use calc() to set textarea height for custom CSS
----------------------------+-----------------------------
 Reporter:  michaelarestad  |       Owner:  michaelarestad
     Type:  defect (bug)    |      Status:  accepted
 Priority:  normal          |   Milestone:  4.7
Component:  Customize       |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  needs-patch     |     Focuses:  ui
----------------------------+-----------------------------
Changes (by westonruter):

 * keywords:  has-patch => needs-patch


Comment:

 @michaelarestad yeah, I can confirm that the scrollbars don't show up
 normally now. However, I see one defect and one possible improvement: the
 padding in the section heading now seems to be cut at the top now in the
 Custom CSS section whereas it has the expected amount of whitespace (more)
 in the other sections.

 Also, do you think the margin at the bottom could be removed?

 Also, thinking about integrating with Jetpack where it will add additional
 controls to this section (see #38672, cc @georgestephanis), how about if
 the margin at the bottom is removed if it is the last item in the list,
 for example: `li.customize-control-custom_css:last-child { margin-bottom:
 0; }`

 And also, the full-section height of the textarea should likewise probably
 only be done if there is only one control in the section. So instead of
 the `#sub-accordion-section-custom_css textarea` selector, what about:
 `.customize-section-description-container + #customize-control-custom_css
 :last-child`. This will ensure it is the first and last control in the
 section.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38755#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list