[wp-trac] [WordPress Trac] #38678: Video Headers: Improve Basic Accessibility

WordPress Trac noreply at wordpress.org
Sat Nov 12 00:46:38 UTC 2016


#38678: Video Headers: Improve Basic Accessibility
------------------------------------+----------------------------
 Reporter:  davidakennedy           |       Owner:  joemcgill
     Type:  defect (bug)            |      Status:  assigned
 Priority:  normal                  |   Milestone:  4.7
Component:  Themes                  |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:  accessibility
------------------------------------+----------------------------

Comment (by bradyvercher):

 In [attachment:38678.4.diff]:

 * Adds a `setButton()` method. I'm not sure if this is the same as what
 @joemcgill had in mind for [attachment:38678.3.diff].
 * Calls `setButton()` in each handler when the video can play.
 * Updates the URL for the YouTube API based on @afercia's [comment:18
 comment].
 * Uses `document.createEvent()` in IE in the `trigger()` method. Event
 constructors aren't available before [https://developer.mozilla.org/en-
 US/docs/Web/API/Event/Event IE 11 according to MDN] and `createEvent()` is
 [https://developer.microsoft.com/en-us/microsoft-
 edge/platform/documentation/dev-guide/dom/#dom-event-constructors
 deprecated in Edge according to MSDN].
 * Declares the `YT` variable as a global using a JSHint directive instead
 of defining it throughout the file.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38678#comment:30>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list