[wp-trac] [WordPress Trac] #38476: Twenty Seventeen: Focused controls may be hidden by the top menu.

[WordPress Trac]

#38476: Twenty Seventeen: Focused controls may be hidden by the top menu.
-------------------------------------------------+-------------------------
 Reporter:  afercia                              |       Owner:
     Type:  defect (bug)                         |  davidakennedy
 Priority:  normal                               |      Status:  reopened
Component:  Bundled Theme                        |   Milestone:  4.7
 Severity:  normal                               |     Version:
 Keywords:  has-screenshots has-patch needs-     |  Resolution:
  testing dev-feedback                           |     Focuses:  ui,
                                                 |  accessibility
-------------------------------------------------+-------------------------

Comment (by davidakennedy):

 Thanks @afercia for the feedback! In [attachment:38476.7.patch], I've made
 some changes to narrow the selectors. Do we need to filter for hidden
 elements? I thought they couldn't receive focus already? Also, `.filter`
 can be a performance hog, so I'm hesitant to use it.

 > this appears to be working for me, what circumstances caused issues on
 your end?

 @Fencer04 I realized I didn't answer your question from above. It was not
 accounting for the admin bar height. So it worked, just not as well when
 logged in. Thanks for your continued work on this! It's been super
 helpful.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38476#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform