[wp-trac] [WordPress Trac] #38397: Twenty Seventeen: Mobile menu parent items require double tap
WordPress Trac
noreply at wordpress.org
Sat Nov 12 00:09:16 UTC 2016
#38397: Twenty Seventeen: Mobile menu parent items require double tap
-------------------------------------+----------------------------
Reporter: celloexpressions | Owner:
Type: defect (bug) | Status: new
Priority: low | Milestone: 4.7
Component: Bundled Theme | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing | Focuses: accessibility
-------------------------------------+----------------------------
Comment (by davidakennedy):
Thanks all for the work and debugging here!
In [attachment:38397.2.patch], I added the attribute to the `<a>` and not
the `<li>`. I can confirm it helps accessibility, as @afercia mentioned.
But in some simulated testing in Browserstack, it didn't solve the
original issue in this ticket – even though the `<a>` is a sibling element
to the `<ul>`. It's not a parent any longer.
I'd love it if someone with a real Windows device could test this though.
I'd like to avoid browser sniffing if at all possible.
@sami.keijonen Sometimes code isn't perfect – pretty sure I helped write
the initial accessible dropdown code for _s. :) But it's great that the
bug is known now, and can be fixed. I have a running list of improvements
to roll back to Underscores after Twenty Seventeen launches.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/38397#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list