[wp-trac] [WordPress Trac] #38391: Twenty Seventeen: Background colour for header

[WordPress Trac]

#38391: Twenty Seventeen: Background colour for header
--------------------------------------+----------------------------
 Reporter:  laurelfulford             |       Owner:  davidakennedy
     Type:  defect (bug)              |      Status:  assigned
 Priority:  normal                    |   Milestone:  4.7
Component:  Bundled Theme             |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:
--------------------------------------+----------------------------

Comment (by davidakennedy):

 @Idealien Thanks for the detailed feedback here!

 I tested your patch quite a bit yesterday, ran into some of the same
 issues and didn't have time to comment. Something else is causing
 problems, and I'm not sure what. Technically, `has_custom_header()` should
 be able to be used as an active callback function and work, but it does
 not. And has the same issues. See:
 https://core.trac.wordpress.org/browser/trunk/src/wp-
 includes/theme.php#L1395

 I'll try to get some more eyes on this. Thanks again for your efforts!

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38391#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform