[wp-trac] [WordPress Trac] #38738: Remove front page restrictions from new custom header functions

[WordPress Trac]

#38738: Remove front page restrictions from new custom header functions
---------------------------+--------------------
 Reporter:  peterwilsoncc  |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  4.7
Component:  Themes         |     Version:  trunk
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:
---------------------------+--------------------

Comment (by flixos90):

 Replying to [comment:8 joemcgill]:
 > I agree with you that the naming is a bit clunky, though. I wonder if
 there is a better place to include the logic from the proposed
 `is_header_video_active()` rather than including another function. Perhaps
 something we could check in `has_header_video()` depending on context?

 I think a dedicated function makes sense. `has_header_video()` should only
 check if a header video is set, not whether it should show on the current
 template. I certainly agree the naming could be improved; though regarding
 your improvement I also agree with @bradyvercher hthat
 `is_header_video_supported()` sounds more like it would check for general
 support.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38738#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform