[wp-trac] [WordPress Trac] #38738: Remove front page restrictions from new custom header functions
WordPress Trac
noreply at wordpress.org
Fri Nov 11 19:09:37 UTC 2016
#38738: Remove front page restrictions from new custom header functions
---------------------------+--------------------
Reporter: peterwilsoncc | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 4.7
Component: Themes | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch | Focuses:
---------------------------+--------------------
Comment (by bradyvercher):
Replying to [comment:5 flixos90]:
> If a theme had multiple areas where it showed the header markup, it
would need to pass the variable each time whereas the theme support
approach allows to handle it in one central location.
I think that's an extremely rare edge case, but that does assume you want
to use the same behavior each time, so you do lose a little flexibility.
In either case, the possibility for overriding the default behavior is
there, so I'm cool with either approach.
I can't really think of any other functions that check a template
conditional like this that could help influence the naming, but
`is_header_video_supported()` sounds like it would be doing the same thing
as `current_theme_supports( 'custom-header', 'video' )`.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/38738#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list