[wp-trac] [WordPress Trac] #38678: Video Headers: Improve Basic Accessibility
WordPress Trac
noreply at wordpress.org
Fri Nov 11 17:42:57 UTC 2016
#38678: Video Headers: Improve Basic Accessibility
------------------------------------+----------------------------
Reporter: davidakennedy | Owner: joemcgill
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 4.7
Component: Themes | Version:
Severity: normal | Resolution:
Keywords: has-patch dev-feedback | Focuses: accessibility
------------------------------------+----------------------------
Comment (by afercia):
Replying to [comment:19 bradyvercher]:
> Good catch on those. The whitespace changes don't really follow the
[https://make.wordpress.org/core/handbook/best-practices/coding-
standards/javascript/#arrays-and-function-calls examples in the JS coding
standards]. Should those be updated?
As far as I know they haven't changed :) They should be followed as much
as possible, so probably some of the changes shouldn't be there. I think
we all work on different projects and remembering and applying different
coding standards sometimes can be a bit hard.
> That's similar to the `YT.ready()` callback, but if we define it, then
it'll create a conflict with any other code that's also trying to define
it.
Got it, thanks.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/38678#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list